[jitsi-dev] Copyimg from chat window broken


#1

Hey all,

It appears that copying from the view area of a chat window now also grabs
a bunch of hidden stuff. We had this quite nicely aligned before so this
must have regressed recently.

Ideas?
Emil

--sent from my mobile


#2

Hi,

could you please give an example, was there images, smilies, links,
combination of that, protocol?
I cannot reproduce it, tried various combinations and chats.

Devs, anybody to have experienced the same?

Thanks
damencho

···

On Fri, Nov 21, 2014 at 5:52 AM, Emil Ivov <emcho@jitsi.org> wrote:

Hey all,

It appears that copying from the view area of a chat window now also grabs a
bunch of hidden stuff. We had this quite nicely aligned before so this must
have regressed recently.

Ideas?
Emil

--sent from my mobile

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Hi Emil and others,

I had a quick look, and discovered the following:

1. Copying of hyperlinks fails: it takes part of the anchor tag and part
of the "anchored" text. (I believe this is new, because before the
change hyperlinks were disabled for HTML content.)
2. System messages don't have a newline character, so all system
messages are concatenated on a single line, including the next message's
header.

Additionally, I've also noticed a few days earlier that for System
messages variable 'lastMessageUID' is updated, however the system
message does not contain a lastMessageUID. As a result you get the
occasional logging WARN about a missing lastMessageUID. As I understand
it we should not store the UID with the system message as I suspect the
lastMessageUID is used for the purpose of correcting the last sent
message, but I'm thinking of lowering the log message to debug or remove
it alltogether.

@Emil: does any of this relate to your case?

Danny

···

On 21-11-14 04:52, Emil Ivov wrote:

Hey all,

It appears that copying from the view area of a chat window now also
grabs a bunch of hidden stuff. We had this quite nicely aligned before
so this must have regressed recently.

Ideas?
Emil

--sent from my mobile

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hi Emil,

I've fixed some of this with recent commits. Could you check to see if
you still have issues?

Danny

···

On 21-11-14 04:52, Emil Ivov wrote:

Hey all,

It appears that copying from the view area of a chat window now also
grabs a bunch of hidden stuff. We had this quite nicely aligned before
so this must have regressed recently.

Ideas?
Emil

--sent from my mobile

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev