[jitsi-dev] Commit messages


#1

Hello team, everyone

Could you please take a bit more care when crafting commit messages?
The rule of thumb is to write a subject line with a maximum length of ca. 50
characters, a blank line, and if necessary a body explaining /why/ the
change was made.

The article in [1] describes this in more detail, but just have a look at
the summaries on GitHub [2,3,4] to see how ugly the cutoff currently is. The
ellipsis dots there shouldn't show the rest of subject, but rather the body.

Thanks for your help and future effort!
Ingo

[1] http://chris.beams.io/posts/git-commit/
[2] https://github.com/jitsi/jitsi-videobridge/commits/master
[3] https://github.com/jitsi/libjitsi/commits/master
[4] https://github.com/jitsi/ice4j/commits/master


#2

Hi Ingo !

Thanks for the suggestion ! Will certainly try to follow these rules !

Regards,
Pawel

···

On Thu, Mar 31, 2016 at 3:31 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Hello team, everyone

Could you please take a bit more care when crafting commit messages?
The rule of thumb is to write a subject line with a maximum length of ca. 50
characters, a blank line, and if necessary a body explaining /why/ the
change was made.

The article in [1] describes this in more detail, but just have a look at
the summaries on GitHub [2,3,4] to see how ugly the cutoff currently is. The
ellipsis dots there shouldn't show the rest of subject, but rather the body.

Thanks for your help and future effort!
Ingo

[1] http://chris.beams.io/posts/git-commit/
[2] https://github.com/jitsi/jitsi-videobridge/commits/master
[3] https://github.com/jitsi/libjitsi/commits/master
[4] https://github.com/jitsi/ice4j/commits/master


#3

Cool! Thank you, Ingo!


#4

Hello Ingo, guys, I agree that we need better formatted commit messages. Thank you for bringing this up Ingo. I’ve been trying to follow this rule in the past, but sometimes I forget about it. I’ll try to enforce it in all of my commits.

- George

···

On Apr 1, 2016, at 10:32 AM, Lyubomir Marinov <lyubomir.marinov@jitsi.org> wrote:

Cool! Thank you, Ingo!

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#5

Same here. Thanks for bringing it up.

Boris

···

On 01/04/16 10:32, Paweł Domas wrote:

Hi Ingo !

Thanks for the suggestion ! Will certainly try to follow these rules !


#6

Completely agree. I’ll follow the rules as well! Thanks Ingo!

Yana

···

On 1 Apr 2016, at 10:54 AM, Boris Grozev <boris@jitsi.org> wrote:

On 01/04/16 10:32, Paweł Domas wrote:

Hi Ingo !

Thanks for the suggestion ! Will certainly try to follow these rules !

Same here. Thanks for bringing it up.

Boris

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev