[jitsi-dev] Comma in display name causes wrong call history

#1

Hey

If a display name contains a comma, the call history service is confused and
thinks the two parts of one name are multiple call participants. The
attached patch slightly changes the format in the history records:
- If the name contains a quote (e.g. Jane"Doe, escape it to Jane\"Doe)
- Quote all names in the history record (e.g. "Doe, Jane" instead of Doe,
Jane)
- Read the full name as a quoted string

Existing records are not changed and continue to show the same content (i.e.
Doe instead of Doe, Jane).

Any objections before I push that?

Ingo

callhistory-displayname-comma.patch (2.27 KB)

#2

Hi,

seems ok to me and as long as old behaviour is unchanged.

Thanks
damencho

ยทยทยท

On Tue, Mar 18, 2014 at 12:46 PM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Hey

If a display name contains a comma, the call history service is confused and
thinks the two parts of one name are multiple call participants. The
attached patch slightly changes the format in the history records:
- If the name contains a quote (e.g. Jane"Doe, escape it to Jane\"Doe)
- Quote all names in the history record (e.g. "Doe, Jane" instead of Doe,
Jane)
- Read the full name as a quoted string

Existing records are not changed and continue to show the same content (i.e.
Doe instead of Doe, Jane).

Any objections before I push that?

Ingo

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev