[jitsi-dev] Chatrooms


#1

Hello everyone,

I had discussed the required work for chatrooms with Emil and Yana in
accordance with the roadmap Emil gave :). Here is what I've done so far.

The nickname of the local user is shown in bold along with the notification,
when it is mentioned by any other participant in the chatroom.
I've also added support for nickname tab completion. I've attached a patch
for this. This will work only in chatrooms and not in normal 1 to 1 chats.

I also had a discussion with Emil about role icons. I'm attaching the role
icons screenshot which we have currently. Emil suggested maybe we can
re-arrange how the user list appears. Owner/Admins, Moderator, User - in
that order. I agree with this suggestion. Because, I think we already use
better icons than what other chat clients use. What do you all think?

Thanks,
Purvesh

Chatrooms.patch (8.39 KB)


#2

Hi, Purvesh:

I think the concept works pretty well from a mechanical point of view. Good work so far.

From a usability point of view I would like to see the chatroom participants on the left side and the chat window itself on the right side. In addition, I would put a color coded background behind the moderator and owners, and leave the users' background white.

Thanks for asking!

marc.

···

On Jul 7, 2011, at 12:31 PM, Purvesh Sahoo wrote:

Hello everyone,

I had discussed the required work for chatrooms with Emil and Yana in accordance with the roadmap Emil gave :). Here is what I've done so far.

The nickname of the local user is shown in bold along with the notification, when it is mentioned by any other participant in the chatroom.
I've also added support for nickname tab completion. I've attached a patch for this. This will work only in chatrooms and not in normal 1 to 1 chats.

I also had a discussion with Emil about role icons. I'm attaching the role icons screenshot which we have currently. Emil suggested maybe we can re-arrange how the user list appears. Owner/Admins, Moderator, User - in that order. I agree with this suggestion. Because, I think we already use better icons than what other chat clients use. What do you all think?

Thanks,
Purvesh
<chatroom.png><Chatrooms.patch>

marc.

-------------------------------
Marc Abrams
+1-408-550-6272


#3

participants on the left side and the chat window itself on the right side.

How would that improve usability?

Cheers,
Andreas

···

Am 07.07.2011 22:15, schrieb Marc Abrams:

From a usability point of view I would like to see the chatroom


#4

People read left to right. This is the reason that Skype put the contact lists on the left.

marc.

···

On Jul 7, 2011, at 9:26 PM, Andreas Kuckartz wrote:

Am 07.07.2011 22:15, schrieb Marc Abrams:

From a usability point of view I would like to see the chatroom

participants on the left side and the chat window itself on the right side.

How would that improve usability?

Cheers,
Andreas

marc.

-------------------------------
Marc Abrams
+1-408-550-6272


#5

Hi,
A google studied showed that computer user's has more concentration
directed at upper,center,left,side of the screen while little on the
right side. That's why google ads appear on the right.

Rgds
Adnan

···

On 7/8/11, Andreas Kuckartz <A.Kuckartz@ping.de> wrote:

Am 07.07.2011 22:15, schrieb Marc Abrams:

From a usability point of view I would like to see the chatroom

participants on the left side and the chat window itself on the right side.

How would that improve usability?

Cheers,
Andreas

--
Sent from my mobile device


#6

The question is: what's more important in the interface, the contact
list or the discussion history? The action happens in the chat part of
the screen, so I'd recommend putting the chat pane on the left and the
contact list on the right. But that's just me. :slight_smile:

Peter

···

On 7/8/11 9:08 AM, Marc Abrams wrote:

People read left to right. This is the reason that Skype put the contact lists on the left.

--
Peter Saint-Andre
https://stpeter.im/


#7

Peter is not alone:

+1

Cheers,
Andreas

···

Am 08.07.2011 17:25, schrieb Peter Saint-Andre:

The question is: what's more important in the interface, the contact
list or the discussion history? The action happens in the chat part of
the screen, so I'd recommend putting the chat pane on the left and the
contact list on the right. But that's just me. :slight_smile:


#8

Hi everyone,

I agree with keeping the contact list on the right. That's what almost all
other clients use as well.

I've made a few other tweaks and added the following :

1. Support for the "/me" command. E.g: "/me does f00" is shown as *** User
does f00
2. Some fixes for chatroom join/create cases. We should now be prompted for
a nickname before we join a chatroom, plus a few other fixes.

I'm attaching a patch with the changes!

Thanks,
Purvesh

chatrooms2.patch (23.5 KB)

···

On Sat, Jul 9, 2011 at 9:48 AM, Andreas Kuckartz <A.Kuckartz@ping.de> wrote:

Am 08.07.2011 17:25, schrieb Peter Saint-Andre:
> The question is: what's more important in the interface, the contact
> list or the discussion history? The action happens in the chat part of
> the screen, so I'd recommend putting the chat pane on the left and the
> contact list on the right. But that's just me. :slight_smile:

Peter is not alone:

+1

Cheers,
Andreas


#9

Hi Purvesh,

Your patch is now committed (r8783) and ack-ed.

(more inline)

Hi everyone,

I agree with keeping the contact list on the right. That's what almost all other clients use as well.

I've made a few other tweaks and added the following :

1. Support for the "/me" command. E.g: "/me does f00" is shown as *** User does f00

Cool! :slight_smile:

The Tab key is also very useful! I've just fixed an ArrayIndexOutOfBoundsException in the keyPressed event in the case where you press the tab before entering any text.

2. Some fixes for chatroom join/create cases. We should now be prompted for a nickname before we join a chatroom, plus a few other fixes.

From what I see, I'm prompted for a nickname only if I join an existing Jabber room and even then I don't see the nickname appear anywhere :frowning: When I create the room I'm not asked to enter a nickname. Note that Damian has made some changes in the same classes in the meantime and I have tried to merge your modifications, but maybe I'm missing something. Could you please have a look?

Cheers,
Yana

···

On Jul 16, 2011, at 8:34 PM, Purvesh Sahoo wrote:

I'm attaching a patch with the changes!

Thanks,
Purvesh

On Sat, Jul 9, 2011 at 9:48 AM, Andreas Kuckartz <A.Kuckartz@ping.de> wrote:
Am 08.07.2011 17:25, schrieb Peter Saint-Andre:
> The question is: what's more important in the interface, the contact
> list or the discussion history? The action happens in the chat part of
> the screen, so I'd recommend putting the chat pane on the left and the
> contact list on the right. But that's just me. :slight_smile:

Peter is not alone:

+1

Cheers,
Andreas

<chatrooms2.patch>


#10

Hi Purvesh,

I've made a few other tweaks and added the following :

1. Support for the "/me" command. E.g: "/me does f00" is shown as ***

User does f00

Cool! :slight_smile:

Does this implementation satisfy XEP-0245 ?
http://xmpp.org/extensions/xep-0245.html

Cheers,
Andreas

···

Am 19.07.2011 13:00, schrieb Yana Stamcheva:


#11

Hi Yana,

I'm attaching the patch with the fix for existing jabber rooms as well. We
can now set nickname for rooms by right clicking the room name in the list
of rooms. I've also included a fix for certain cases where the room was
opened but no contact list was displayed.

The patch also includes the fix for not displaying history messages more
than once in case of chatrooms. It should work, although I haven't tested it
extensively.

Thanks,
Purvesh

chatroom-nick.patch (26.6 KB)

···

On Tue, Jul 19, 2011 at 4:30 PM, Yana Stamcheva <yana@jitsi.org> wrote:

Hi Purvesh,

Your patch is now committed (r8783) and ack-ed.

(more inline)

On Jul 16, 2011, at 8:34 PM, Purvesh Sahoo wrote:

> Hi everyone,
>
> I agree with keeping the contact list on the right. That's what almost
all other clients use as well.
>
> I've made a few other tweaks and added the following :
>
> 1. Support for the "/me" command. E.g: "/me does f00" is shown as ***
User does f00

Cool! :slight_smile:

The Tab key is also very useful! I've just fixed an
ArrayIndexOutOfBoundsException in the keyPressed event in the case where you
press the tab before entering any text.

> 2. Some fixes for chatroom join/create cases. We should now be prompted
for a nickname before we join a chatroom, plus a few other fixes.

From what I see, I'm prompted for a nickname only if I join an existing
Jabber room and even then I don't see the nickname appear anywhere :frowning: When I
create the room I'm not asked to enter a nickname. Note that Damian has made
some changes in the same classes in the meantime and I have tried to merge
your modifications, but maybe I'm missing something. Could you please have a
look?

Cheers,
Yana

>
> I'm attaching a patch with the changes!
>
> Thanks,
> Purvesh
>
> On Sat, Jul 9, 2011 at 9:48 AM, Andreas Kuckartz <A.Kuckartz@ping.de> > wrote:
> Am 08.07.2011 17:25, schrieb Peter Saint-Andre:
> > The question is: what's more important in the interface, the contact
> > list or the discussion history? The action happens in the chat part of
> > the screen, so I'd recommend putting the chat pane on the left and the
> > contact list on the right. But that's just me. :slight_smile:
>
> Peter is not alone:
>
> +1
>
> Cheers,
> Andreas
>
>
> <chatrooms2.patch>


#12

Hi,

Yes. I implemented xep-0245. Please let me know if you think I missed
something :slight_smile:

Thanks,
Purvesh

···

On Wed, Jul 20, 2011 at 12:57 AM, Andreas Kuckartz <A.Kuckartz@ping.de>wrote:

Am 19.07.2011 13:00, schrieb Yana Stamcheva:
> Hi Purvesh,
>>
>> I've made a few other tweaks and added the following :
>>
>> 1. Support for the "/me" command. E.g: "/me does f00" is shown as ***
User does f00
>
> Cool! :slight_smile:

Does this implementation satisfy XEP-0245 ?
http://xmpp.org/extensions/xep-0245.html

Cheers,
Andreas


#13

Hi Purvesh,

Your patch is committed and ack-ed.

When testing I stumbled upon the following issues:

- If Click File/Go to chat room... and I'm prompted for nickname, but it's not taken into account. Could you please verify?

- Right clicking "Change room's subject..." from the right button menu in the chat room doesn't seem to work for me. Is it on the bug list ?:slight_smile:

(more inline)

Hi Yana,

I'm attaching the patch with the fix for existing jabber rooms as well. We can now set nickname for rooms by right clicking the room name in the list of rooms.

Do you mean in the "Go to chatroom.." window? I don't see this option. Could you please send a screenshot?

Thanks!
Yana

···

On Aug 2, 2011, at 5:12 AM, Purvesh Sahoo wrote:

I've also included a fix for certain cases where the room was opened but no contact list was displayed.

The patch also includes the fix for not displaying history messages more than once in case of chatrooms. It should work, although I haven't tested it extensively.

Thanks,
Purvesh

On Tue, Jul 19, 2011 at 4:30 PM, Yana Stamcheva <yana@jitsi.org> wrote:
Hi Purvesh,

Your patch is now committed (r8783) and ack-ed.

(more inline)

On Jul 16, 2011, at 8:34 PM, Purvesh Sahoo wrote:

> Hi everyone,
>
> I agree with keeping the contact list on the right. That's what almost all other clients use as well.
>
> I've made a few other tweaks and added the following :
>
> 1. Support for the "/me" command. E.g: "/me does f00" is shown as *** User does f00

Cool! :slight_smile:

The Tab key is also very useful! I've just fixed an ArrayIndexOutOfBoundsException in the keyPressed event in the case where you press the tab before entering any text.

> 2. Some fixes for chatroom join/create cases. We should now be prompted for a nickname before we join a chatroom, plus a few other fixes.

From what I see, I'm prompted for a nickname only if I join an existing Jabber room and even then I don't see the nickname appear anywhere :frowning: When I create the room I'm not asked to enter a nickname. Note that Damian has made some changes in the same classes in the meantime and I have tried to merge your modifications, but maybe I'm missing something. Could you please have a look?

Cheers,
Yana

>
> I'm attaching a patch with the changes!
>
> Thanks,
> Purvesh
>
> On Sat, Jul 9, 2011 at 9:48 AM, Andreas Kuckartz <A.Kuckartz@ping.de> wrote:
> Am 08.07.2011 17:25, schrieb Peter Saint-Andre:
> > The question is: what's more important in the interface, the contact
> > list or the discussion history? The action happens in the chat part of
> > the screen, so I'd recommend putting the chat pane on the left and the
> > contact list on the right. But that's just me. :slight_smile:
>
> Peter is not alone:
>
> +1
>
> Cheers,
> Andreas
>
>
> <chatrooms2.patch>

<chatroom-nick.patch>


#14

Hi Yana,

Hi Purvesh,

Your patch is committed and ack-ed.

When testing I stumbled upon the following issues:

- If Click File/Go to chat room... and I'm prompted for nickname, but it's
not taken into account. Could you please verify?

Does this happen when you create a new room? Or while joining an existing
room.

- Right clicking "Change room's subject..." from the right button menu in
the chat room doesn't seem to work for me. Is it on the bug list ?:slight_smile:

Yes. I've noticed this bug too. Apparently it worked for some rooms and
didn't for other. The room.getSubject() returns null on some occasions, even
after the subject is set. I'll investigate the issue.

(more inline)

> Hi Yana,
>
> I'm attaching the patch with the fix for existing jabber rooms as well.
We can now set nickname for rooms by right clicking the room name in the
list of rooms.

Do you mean in the "Go to chatroom.." window? I don't see this option.
Could you please send a screenshot?

The code for this wasn't committed with the patch you applied :slight_smile: Hence it
wasn't visible! I'll enable this. I've attached a screenshot with this
email. Maybe we could use another icon?

Thanks,
Purvesh

···

On Thu, Aug 4, 2011 at 3:10 AM, Yana Stamcheva <yana@jitsi.org> wrote:

On Aug 2, 2011, at 5:12 AM, Purvesh Sahoo wrote:

Thanks!
Yana

> I've also included a fix for certain cases where the room was opened but
no contact list was displayed.

> The patch also includes the fix for not displaying history messages more
than once in case of chatrooms. It should work, although I haven't tested it
extensively.
>
> Thanks,
> Purvesh
>
> On Tue, Jul 19, 2011 at 4:30 PM, Yana Stamcheva <yana@jitsi.org> wrote:
> Hi Purvesh,
>
> Your patch is now committed (r8783) and ack-ed.
>
> (more inline)
>
> On Jul 16, 2011, at 8:34 PM, Purvesh Sahoo wrote:
>
> > Hi everyone,
> >
> > I agree with keeping the contact list on the right. That's what almost
all other clients use as well.
> >
> > I've made a few other tweaks and added the following :
> >
> > 1. Support for the "/me" command. E.g: "/me does f00" is shown as ***
User does f00
>
> Cool! :slight_smile:
>
> The Tab key is also very useful! I've just fixed an
ArrayIndexOutOfBoundsException in the keyPressed event in the case where you
press the tab before entering any text.
>
> > 2. Some fixes for chatroom join/create cases. We should now be prompted
for a nickname before we join a chatroom, plus a few other fixes.
>
> From what I see, I'm prompted for a nickname only if I join an existing
Jabber room and even then I don't see the nickname appear anywhere :frowning: When I
create the room I'm not asked to enter a nickname. Note that Damian has made
some changes in the same classes in the meantime and I have tried to merge
your modifications, but maybe I'm missing something. Could you please have a
look?
>
> Cheers,
> Yana
>
> >
> > I'm attaching a patch with the changes!
> >
> > Thanks,
> > Purvesh
> >
> > On Sat, Jul 9, 2011 at 9:48 AM, Andreas Kuckartz <A.Kuckartz@ping.de> > wrote:
> > Am 08.07.2011 17:25, schrieb Peter Saint-Andre:
> > > The question is: what's more important in the interface, the contact
> > > list or the discussion history? The action happens in the chat part
of
> > > the screen, so I'd recommend putting the chat pane on the left and
the
> > > contact list on the right. But that's just me. :slight_smile:
> >
> > Peter is not alone:
> >
> > +1
> >
> > Cheers,
> > Andreas
> >
> >
> > <chatrooms2.patch>
>
>
> <chatroom-nick.patch>


#15

Hi Purvesh,

Hi Yana,

Hi Purvesh,

Your patch is committed and ack-ed.

When testing I stumbled upon the following issues:

- If Click File/Go to chat room... and I'm prompted for nickname, but it's not taken into account. Could you please verify?

Does this happen when you create a new room? Or while joining an existing room.

When I create a new room.

- Right clicking "Change room's subject..." from the right button menu in the chat room doesn't seem to work for me. Is it on the bug list ?:slight_smile:

Yes. I've noticed this bug too. Apparently it worked for some rooms and didn't for other. The room.getSubject() returns null on some occasions, even after the subject is set. I'll investigate the issue.

Ok.

(more inline)

> Hi Yana,
>
> I'm attaching the patch with the fix for existing jabber rooms as well. We can now set nickname for rooms by right clicking the room name in the list of rooms.

Do you mean in the "Go to chatroom.." window? I don't see this option. Could you please send a screenshot?

The code for this wasn't committed with the patch you applied :slight_smile: Hence it wasn't visible! I'll enable this. I've attached a screenshot with this email. Maybe we could use another icon?

Oh ok. I'll think of an icon and send to you next week.

Cheers,
Yana

···

On Aug 8, 2011, at 12:26 PM, Purvesh Sahoo wrote:

On Thu, Aug 4, 2011 at 3:10 AM, Yana Stamcheva <yana@jitsi.org> wrote:
On Aug 2, 2011, at 5:12 AM, Purvesh Sahoo wrote:

Thanks,
Purvesh
  
Thanks!
Yana

> I've also included a fix for certain cases where the room was opened but no contact list was displayed.

> The patch also includes the fix for not displaying history messages more than once in case of chatrooms. It should work, although I haven't tested it extensively.
>
> Thanks,
> Purvesh
>
> On Tue, Jul 19, 2011 at 4:30 PM, Yana Stamcheva <yana@jitsi.org> wrote:
> Hi Purvesh,
>
> Your patch is now committed (r8783) and ack-ed.
>
> (more inline)
>
> On Jul 16, 2011, at 8:34 PM, Purvesh Sahoo wrote:
>
> > Hi everyone,
> >
> > I agree with keeping the contact list on the right. That's what almost all other clients use as well.
> >
> > I've made a few other tweaks and added the following :
> >
> > 1. Support for the "/me" command. E.g: "/me does f00" is shown as *** User does f00
>
> Cool! :slight_smile:
>
> The Tab key is also very useful! I've just fixed an ArrayIndexOutOfBoundsException in the keyPressed event in the case where you press the tab before entering any text.
>
> > 2. Some fixes for chatroom join/create cases. We should now be prompted for a nickname before we join a chatroom, plus a few other fixes.
>
> From what I see, I'm prompted for a nickname only if I join an existing Jabber room and even then I don't see the nickname appear anywhere :frowning: When I create the room I'm not asked to enter a nickname. Note that Damian has made some changes in the same classes in the meantime and I have tried to merge your modifications, but maybe I'm missing something. Could you please have a look?
>
> Cheers,
> Yana
>
> >
> > I'm attaching a patch with the changes!
> >
> > Thanks,
> > Purvesh
> >
> > On Sat, Jul 9, 2011 at 9:48 AM, Andreas Kuckartz <A.Kuckartz@ping.de> wrote:
> > Am 08.07.2011 17:25, schrieb Peter Saint-Andre:
> > > The question is: what's more important in the interface, the contact
> > > list or the discussion history? The action happens in the chat part of
> > > the screen, so I'd recommend putting the chat pane on the left and the
> > > contact list on the right. But that's just me. :slight_smile:
> >
> > Peter is not alone:
> >
> > +1
> >
> > Cheers,
> > Andreas
> >
> >
> > <chatrooms2.patch>
>
>
> <chatroom-nick.patch>

<chatroom-nickname.png>