[jitsi-dev] Bug in VoIPMetricsReportBlock


#1

Hi

I think the following code has a bug,

https://github.com/jitsi/libjitsi/blob/master/src/org/jitsi/service/neomedia/rtp/RTCPExtendedReport.java#L304

if (blockLength != 8 * 4)

It should be 9 * 4.

Based on the rfc 3611, it is in 32 bit words minus one.

https://tools.ietf.org/html/rfc3611#section-3

   block length: 16 bits
         The length of this report block, including the header, in 32-
         bit words minus one.

Please see the network capture as attached.

Thanks,

/Kaiduan

jigasi-impossible-exception.pcap (1.22 MB)

···

--
Founder of Goodstartsoft
https://www.goodstartsoft.com


#2

Hi Kaiduan,

···

On 12/10/2017 08:37, Kaiduan Xie wrote:

Hi

I think the following code has a bug,

https://github.com/jitsi/libjitsi/blob/master/src/org/jitsi/service/neomedia/rtp/RTCPExtendedReport.java#L304

if(blockLength !=8*4)

It should be 9 * 4.

Based on the rfc 3611, it is in 32 bit wordsminus one.

https://tools.ietf.org/html/rfc3611#section-3

block length: 16 bits The length of this report block, including the header, in 32- bit words minus one.

I think you're right. I've tried to fix it here, but I haven't tested:
https://github.com/jitsi/libjitsi/pull/376

Regards,
Boris


#3

Boris,

Thanks.

I have tested this in production, this happens while making PSTN call to
some carrier.

Best regards,

/Kaiduan

···

On Mon, Oct 23, 2017 at 1:19 PM, Boris Grozev <boris@jitsi.org> wrote:

Hi Kaiduan,

On 12/10/2017 08:37, Kaiduan Xie wrote:

Hi

I think the following code has a bug,

https://github.com/jitsi/libjitsi/blob/master/src/org/jitsi/
service/neomedia/rtp/RTCPExtendedReport.java#L304

if(blockLength !=8*4)

It should be 9 * 4.

Based on the rfc 3611, it is in 32 bit wordsminus one.

https://tools.ietf.org/html/rfc3611#section-3

block length: 16 bits The length of this report block, including the
header, in 32- bit words minus one.

I think you're right. I've tried to fix it here, but I haven't tested:
https://github.com/jitsi/libjitsi/pull/376

Regards,
Boris

--
Founder of Goodstartsoft
https://www.goodstartsoft.com