[jitsi-dev] Availability of new features in the testing branch


#1

Hi, Jitsi Team.

I read on the Jitsi site about the implementation of adaptivity [1] in
the bridge based on the available bandwidth. This sounds very
interesting! Thank you very much for implementing this!

I would like to know if this feature is available in the testing branch
to do some testing.

On the other hand, I would also like to know if the new vertical layout
for group calls is available on testing branch. I noticed meet.jit.si
shows a smaller thumbnail than the one shown in the testing branch, so
it made me think maybe there are differences still not implemented in
the testing branch regarding the interface.

Thanks in advance.

Kind regards,
Daniel

[1] https://jitsi.org/news/adaptivity


#2

Hi again.

Hi, Jitsi Team.

I read on the Jitsi site about the implementation of adaptivity [1] in
the bridge based on the available bandwidth. This sounds very
interesting! Thank you very much for implementing this!

I would like to know if this feature is available in the testing branch
to do some testing.

On the other hand, I would also like to know if the new vertical layout
for group calls is available on testing branch. I noticed meet.jit.si
shows a smaller thumbnail than the one shown in the testing branch, so
it made me think maybe there are differences still not implemented in
the testing branch regarding the interface.

[1] https://jitsi.org/news/adaptivity

I am observing in meet.jit.si that screen sharing works in Firefox
without the need of the Jidesha Addon. Is this another new functionality
introduced? I am also observing this behavior in the version I built
with the code obtained from Github.

I would like to know if we could have this available in testing branch
as well.

Thanks again.

Kind regards,
Daniel

···

On 24/06/17 22:42, Daniel wrote:


#3

Hi Daniel,

The jidesha extension is not required with Firefox 52 and later. All you
need to do is tweak config.js to not look for an extension (which is the
new default).

Boris

···

On Sun, Jun 25, 2017 at 12:38 PM Daniel <daniel-listas@gmx.net> wrote:

Hi again.

On 24/06/17 22:42, Daniel wrote:

> Hi, Jitsi Team.
>
> I read on the Jitsi site about the implementation of adaptivity [1] in
> the bridge based on the available bandwidth. This sounds very
> interesting! Thank you very much for implementing this!
>
> I would like to know if this feature is available in the testing branch
> to do some testing.
>
> On the other hand, I would also like to know if the new vertical layout
> for group calls is available on testing branch. I noticed meet.jit.si
> shows a smaller thumbnail than the one shown in the testing branch, so
> it made me think maybe there are differences still not implemented in
> the testing branch regarding the interface.
>
>
> [1] https://jitsi.org/news/adaptivity

I am observing in meet.jit.si that screen sharing works in Firefox
without the need of the Jidesha Addon. Is this another new functionality
introduced? I am also observing this behavior in the version I built
with the code obtained from Github.

I would like to know if we could have this available in testing branch
as well.

Thanks again.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#4

Hi Daniel,

Hi, Boris.

The jidesha extension is not required with Firefox 52 and later. All you
need to do is tweak config.js to not look for an extension (which is the
new default).

Thanks for confirm and thank you also very much for implementing this!
It still does not seem to be available in the testing repo. Do you have
any estimation of when we could have this there?

For Chrome are there any plans to integrate screen sharing also without
needing to use Jidesha?

I would also appreciate if you could confirm if we have currently
available in the testing repo the bridge's adaptivity and the new
vertical layout for group calls.

Thanks for your time.

Kind regards,
Daniel

···

On 25/06/17 18:03, Boris Grozev wrote:


#5

Hi,

Hi Daniel,

Hi, Boris.

The jidesha extension is not required with Firefox 52 and later. All you
need to do is tweak config.js to not look for an extension (which is the
new default).

Thanks for confirm and thank you also very much for implementing this!
It still does not seem to be available in the testing repo. Do you have
any estimation of when we could have this there?

This all is already in testing.

For Chrome are there any plans to integrate screen sharing also without
needing to use Jidesha?

This is a chrome requirement, I'm not aware of them doing such
implementation at the moment.

I would also appreciate if you could confirm if we have currently
available in the testing repo the bridge's adaptivity and the new
vertical layout for group calls.

Yep, it is in testing.

Regards
damencho

Thanks for your time.

Kind regards,
Daniel

···

On Jun 25, 2017 14:40, "Daniel" <daniel-listas@gmx.net> wrote:
On 25/06/17 18:03, Boris Grozev wrote:

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#6

Hi,

Hi, Damian.

> > The jidesha extension is not required with Firefox 52 and later.
> > All you need to do is tweak config.js to not look for an extension
> > (which is the new default).

> Thanks for confirm and thank you also very much for implementing this!
> It still does not seem to be available in the testing repo. Do you have
> any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?

> For Chrome are there any plans to integrate screen sharing also without
> needing to use Jidesha?

This is a chrome requirement, I'm not aware of them doing such
implementation at the moment.

I see. So, according to what you say, it depends on the client side
(browser) support.

> I would also appreciate if you could confirm if we have currently
> available in the testing repo the bridge's adaptivity and the new
> vertical layout for group calls.

Yep, it is in testing.

Great! Thank you very much for confirming.

Kind regards,
Daniel

P.S.: If you have something else to add about my usecase that leads me
to creating packages, it would be great :slight_smile: In my last reply I was
elaborating on the basis of this need.

···

On 25/06/17 20:39, Damian Minkov wrote:


#7

Hi,

Hi, Damian.

> > The jidesha extension is not required with Firefox 52 and later.
> > All you need to do is tweak config.js to not look for an extension
> > (which is the new default).

> Thanks for confirm and thank you also very much for implementing
> this!It still does not seem to be available in the testing repo.
> Doyou have any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?

> For Chrome are there any plans to integrate screen sharing also
> without needing to use Jidesha?

This is a chrome requirement, I'm not aware of them doing such
implementation at the moment.

I see. So, according to what you say, it depends on the client side
(browser) support.

> I would also appreciate if you could confirm if we have currently
> available in the testing repo the bridge's adaptivity and the new
> vertical layout for group calls.

Yep, it is in testing.

Great! Thank you very much for confirming.

Kind regards,
Daniel

P.S.: If you have something else to add about my usecase that leads me
to creating packages, it would be great :slight_smile: In my last reply I was
elaborating on the basis of this need.

···

On 25/06/17 20:39, Damian Minkov wrote:


#8

Hi,

Hi, Damian.

> > The jidesha extension is not required with Firefox 52 and later.
> > All you need to do is tweak config.js to not look for an extension
> > (which is the new default).

> Thanks for confirm and thank you also very much for implementing
> this! It still does not seem to be available in the testing repo.
> Do you have any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?

> For Chrome are there any plans to integrate screen sharing also
> without needing to use Jidesha?

This is a chrome requirement, I'm not aware of them doing such
implementation at the moment.

I see. So, according to what you say, it depends on the client side
(browser) support.

> I would also appreciate if you could confirm if we have currently
> available in the testing repo the bridge's adaptivity and the new
> vertical layout for group calls.

Yep, it is in testing.

Great! Thank you very much for confirming.

Kind regards,
Daniel

P.S.: If you have something else to add about my usecase that leads me
to creating packages, it would be great :slight_smile: In my last reply I was
elaborating on the basis of this need.

···

On 25/06/17 20:39, Damian Minkov wrote:


#9

Hi,

Hi, Damian.

> > The jidesha extension is not required with Firefox 52 and later.
> > All you need to do is tweak config.js to not look for an extension
> > (which is the new default).

> Thanks for confirm and thank you also very much for implementing
> this! It still does not seem to be available in the testing repo.
> Do you have any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?

> For Chrome are there any plans to integrate screen sharing also
> without needing to use Jidesha?

This is a chrome requirement, I'm not aware of them doing such
implementation at the moment.

I see. So, according to what you say, it depends on the client side
(browser) support.

> I would also appreciate if you could confirm if we have currently
> available in the testing repo the bridge's adaptivity and the new
> vertical layout for group calls.

Yep, it is in testing.

Great! Thank you very much for confirming.

Kind regards,
Daniel

P.S.: If you have something else to add about my usecase that leads me
to creating packages, it would be great :slight_smile: In my last reply I was
elaborating on the basis of this need.

···

On 25/06/17 20:39, Damian Minkov wrote:


#10

Hi, Damian.

> I would also appreciate if you could confirm if we have currently
> available in the testing repo the bridge's adaptivity and the new
> vertical layout for group calls.

Yep, it is in testing.

Today I tried a meet with several participants, and it seems that I do
not have active vertical layout for the thumbnails. Is it possible that
you have added a new option for config.js that I have to manually add?

Also the thumbnail box seems to have not changed instead of having a
smaller rectangular design like the one in meet.jit.si.

https://ibin.co/3TNA3dSgPAMe.jpg

Versions:

jitsi-meet: 1.0.2251-1
jitsi-meet-prosody: 1.0.2118-1
jitsi-meet-web: 1.0.2118-1
jitsi-meet-web-config: 1.0.2118-1

Thanks in advance.

Kind regards,
Daniel

···

On 25/06/17 20:39, Damian Minkov wrote:


#11

Yes, it used to be -1. It changed to 51in February:
https://github.com/jitsi/jitsi-meet/pull/1362

Boris

···

On 26/06/2017 09:40, Daniel wrote:

On 25/06/17 20:39, Damian Minkov wrote:

Hi,

Hi, Damian.

The jidesha extension is not required with Firefox 52 and later.
All you need to do is tweak config.js to not look for an extension
(which is the new default).

Thanks for confirm and thank you also very much for implementing
this!It still does not seem to be available in the testing repo.
Doyou have any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?


#12

This is also browser related and was implemented by Firefox and is
available since version 52.

···

On Mon, Jun 26, 2017 at 9:33 AM, Daniel <daniel-listas@gmx.net> wrote:

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?


#13

Hi again, Damian.

The jidesha extension is not required with Firefox 52 and later.
All you need to do is tweak config.js to not look for an extension
(which is the new default).

Thanks for confirm and thank you also very much for implementing
this! It still does not seem to be available in the testing repo.
Do you have any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?

I just updated to the latest versions in testing repo:

* jitsi-meet 1.0.2187-1.
* jitsi-meet-web 1.0.2052-1.
* jitsi-meet-web-config 1.0.2052-1
* jitsi-meet-prosody 1.0.2052-1
* jitsi-videobridge 963-1

This seems to break the screen sharing in FF52.

Steps to reproduce it:

1) Click on "Start / Stop screen sharing" button.
2) Select "Windows to share" in the drop-down menu.
3) A thumbnail of the window to share is displayed.
4) Confirm the selection by pressing "Share Selected Window".
5) The orange window sharing icon is displayed a few seconds next to the
camera and microphone sharing icon, but the camera is still transmitting
instead of switching to the window I selected to share.

Are you able to reproduce it?

This was working before upgrading.

Thanks in advance.

Kind regards,
Daniel

···

On 26/06/17 17:05, Daniel wrote:


#14

Hi,

The vertical filmstrip is controlled by property in interface_config.js:
VERTICAL_FILMSTRIP: true.
Do you have a custom one, cause in the source this is enabled by default?

Regards
damencho

···

On Fri, Jul 14, 2017 at 2:06 PM, Daniel Bareiro <daniel-listas@gmx.net> wrote:

Hi, Damian.

On 25/06/17 20:39, Damian Minkov wrote:

> I would also appreciate if you could confirm if we have currently
> available in the testing repo the bridge's adaptivity and the new
> vertical layout for group calls.

Yep, it is in testing.

Today I tried a meet with several participants, and it seems that I do
not have active vertical layout for the thumbnails. Is it possible that
you have added a new option for config.js that I have to manually add?

Also the thumbnail box seems to have not changed instead of having a
smaller rectangular design like the one in meet.jit.si.

https://ibin.co/3TNA3dSgPAMe.jpg

Versions:

jitsi-meet: 1.0.2251-1
jitsi-meet-prosody: 1.0.2118-1
jitsi-meet-web: 1.0.2118-1
jitsi-meet-web-config: 1.0.2118-1

Thanks in advance.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#15

Hi,

Hi, Damian.

Today I tried a meet with several participants, and it seems that I
do not have active vertical layout for the thumbnails. Is it
possible that you have added a new option for config.js that I have
to manually add?

Also the thumbnail box seems to have not changed instead of having a
smaller rectangular design like the one in meet.jit.si.

https://ibin.co/3TNA3dSgPAMe.jpg

Versions:

jitsi-meet: 1.0.2251-1
jitsi-meet-prosody: 1.0.2118-1
jitsi-meet-web: 1.0.2118-1
jitsi-meet-web-config: 1.0.2118-1

Thanks in advance.

The vertical filmstrip is controlled by property in interface_config.js:
VERTICAL_FILMSTRIP: true.

Do you have a custom one, cause in the source this is enabled by
default?

Ah, yes! I have a different file pointed to in Nginx to avoid losing
some custom changes. I see the variable VERTICAL_FILMSTRIP already
existed, but it was set to "false", which makes me think it was not a
new implementation, but only a decision to change the default
configuration. Thanks for the observation.

Comparing both files, I see that in my file there are some lines that
are not in the most recent version:

···

On 14/07/17 16:36, Damian Minkov wrote:

---------------------------------------------------------------------
    CANVAS_EXTRA: 104,
    CANVAS_RADIUS: 0,
    SHADOW_COLOR: '#ffffff',
---------------------------------------------------------------------

Is it advisable to remove them?

I also see that you incorporated some new options:

---------------------------------------------------------------------
MAXIMUM_ZOOMING_COEFFICIENT: 1.3

// SUPPORT_URL: ""
---------------------------------------------------------------------

For videobridge adaptivity is it needed to configure something additional?

Thanks for your time.

Kind regards,
Daniel


#16

Hi,

Yep I see this with latest nightly, will take a closer look tomorrow.

Thanks for the report
damencho

···

On Mon, Jun 26, 2017 at 7:06 PM, Daniel <daniel-listas@gmx.net> wrote:

Hi again, Damian.

On 26/06/17 17:05, Daniel wrote:

The jidesha extension is not required with Firefox 52 and later.
All you need to do is tweak config.js to not look for an extension
(which is the new default).

Thanks for confirm and thank you also very much for implementing
this! It still does not seem to be available in the testing repo.
Do you have any estimation of when we could have this there?

This all is already in testing.

Ah! I already found out why it was not working in the version I
installed from the testing repository:

desktopSharingFirefoxMaxVersionExtRequired: -1,

After changing this to:

desktopSharingFirefoxMaxVersionExtRequired: 51,

It worked without problems. Maybe at some point the default setting was
'-1'. Is the implementation of screen sharing without Jidesha relatively
recent?

I just updated to the latest versions in testing repo:

* jitsi-meet 1.0.2187-1.
* jitsi-meet-web 1.0.2052-1.
* jitsi-meet-web-config 1.0.2052-1
* jitsi-meet-prosody 1.0.2052-1
* jitsi-videobridge 963-1

This seems to break the screen sharing in FF52.

Steps to reproduce it:

1) Click on "Start / Stop screen sharing" button.
2) Select "Windows to share" in the drop-down menu.
3) A thumbnail of the window to share is displayed.
4) Confirm the selection by pressing "Share Selected Window".
5) The orange window sharing icon is displayed a few seconds next to the
camera and microphone sharing icon, but the camera is still transmitting
instead of switching to the window I selected to share.

Are you able to reproduce it?

This was working before upgrading.

Thanks in advance.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#17

Hi,

Hi, Damian.

Today I tried a meet with several participants, and it seems that I
do not have active vertical layout for the thumbnails. Is it
possible that you have added a new option for config.js that I have
to manually add?

Also the thumbnail box seems to have not changed instead of having a
smaller rectangular design like the one in meet.jit.si.

https://ibin.co/3TNA3dSgPAMe.jpg

Versions:

jitsi-meet: 1.0.2251-1
jitsi-meet-prosody: 1.0.2118-1
jitsi-meet-web: 1.0.2118-1
jitsi-meet-web-config: 1.0.2118-1

Thanks in advance.

The vertical filmstrip is controlled by property in interface_config.js:
VERTICAL_FILMSTRIP: true.

Do you have a custom one, cause in the source this is enabled by
default?

Ah, yes! I have a different file pointed to in Nginx to avoid losing
some custom changes. I see the variable VERTICAL_FILMSTRIP already
existed, but it was set to "false", which makes me think it was not a
new implementation, but only a decision to change the default
configuration. Thanks for the observation.

Comparing both files, I see that in my file there are some lines that
are not in the most recent version:

---------------------------------------------------------------------
   CANVAS_EXTRA: 104,
   CANVAS_RADIUS: 0,
   SHADOW_COLOR: '#ffffff',
---------------------------------------------------------------------

Is it advisable to remove them?

They are not used anywhere, so you can safely remove them.

I also see that you incorporated some new options:

---------------------------------------------------------------------
MAXIMUM_ZOOMING_COEFFICIENT: 1.3

// SUPPORT_URL: ""
——————————————————————————————————

You can add those, they should just reflect the default values.

For videobridge adaptivity is it needed to configure something additional?

Nope, it’s enabled by default in the Videobridge, unless you manually disable it in the sip-communicator.properties file.

Cheers,

···

On Jul 15, 2017, at 00:13, Daniel Bareiro <daniel-listas@gmx.net> wrote:
On 14/07/17 16:36, Damian Minkov wrote:

Thanks for your time.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev

--
Saúl


#18

Hi,

Hi, Damian.

Yep I see this with latest nightly, will take a closer look tomorrow.

Thanks for the report

Thank you for confirming this. If you wish, I can open an issue in Github.

Kind regards,
Daniel

···

On 26/06/17 23:29, Damian Minkov wrote:


#19

Hi Daniel,

It is fixed now in nightlies and the fix should arrive soon in testing.

Cheers
damencho

···

On Tue, Jun 27, 2017 at 8:07 AM, Daniel Bareiro <daniel-listas@gmx.net> wrote:

On 26/06/17 23:29, Damian Minkov wrote:

Hi,

Hi, Damian.

Yep I see this with latest nightly, will take a closer look tomorrow.

Thanks for the report

Thank you for confirming this. If you wish, I can open an issue in Github.

Kind regards,
Daniel

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#20

Hi Daniel,

Hi, Damian.

It is fixed now in nightlies and the fix should arrive soon in testing.

Thank you very much for the prompt fix :slight_smile:

Kind regards,
Daniel

···

On 27/06/17 19:08, Damian Minkov wrote: