[jitsi-dev] '*' and '#' as prefix or suffix


#1

Hey,

It seems to me there is a bug which makes impossible to dial numbers
which are prefixed or suffixed with '*' (start) or '#' (hash)
characters.

When I type '*10001' Jitsi sends the following INVITE:

INVITE sip:10001@sip.local SIP/2.0

(note: * is stripped)

the same happens for:

*10001
#10001
10001#

If any of this characters is included within the URI string, it is
passed correctly, for example '111#222' results in:

INVITE sip:111#222@sip.local SIP/2.0

Also prefixing the number with a letter works fine, for example
'a10001' results in:

INVITE sip:a10001@sip.local SIP/2.0

Regards,
Chris


#2

I have an entire office dialing *97 (voicemail) just fine. There is something at your end that is off.

      Lee

···

On 06/28/2011 06:53 AM, Chris Maciejewski wrote:

Hey,

It seems to me there is a bug which makes impossible to dial numbers
which are prefixed or suffixed with '*' (start) or '#' (hash)
characters.

When I type '*10001' Jitsi sends the following INVITE:

INVITE sip:10001@sip.local SIP/2.0


#3

Hey Chris,

Just tried and had no problem calling either of these. How exactly are
you dialing them? Have you tried typing the number in the search field?

Emil

На 28.06.11 12:53, Chris Maciejewski написа:

···

Hey,

It seems to me there is a bug which makes impossible to dial numbers
which are prefixed or suffixed with '*' (start) or '#' (hash)
characters.

When I type '*10001' Jitsi sends the following INVITE:

INVITE sip:10001@sip.local SIP/2.0

(note: * is stripped)

the same happens for:

*10001
#10001
10001#

If any of this characters is included within the URI string, it is
passed correctly, for example '111#222' results in:

INVITE sip:111#222@sip.local SIP/2.0

Also prefixing the number with a letter works fine, for example
'a10001' results in:

INVITE sip:a10001@sip.local SIP/2.0

Regards,
Chris

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
Jitsi
emcho@jitsi.org PHONE: +33.1.77.62.43.30
http://jitsi.org FAX: +33.1.77.62.47.31


#4

I have an entire office dialing *97 (voicemail) just fine. There is
something at your end that is off.

                   Lee

Very odd...

Just tried Jitis nightly build 3561 on Ubuntu and Windows and got the
same result - # characters is stripped.

Please see PDF for more details:

http://dl.dropbox.com/u/3182365/Jitsi-HashCharacter.pdf

Any more information I can provide about my environment that might
help to pin down this strange issue?

Chris


#5

Hi all,

Personnally I have tested on Mac OS X Snow Leopard, Windows 7 32-bit and GNU/Linux Debian x86_64 by calling #XXXX and *XXXX (where XXXX are numbers) and I do not see any problems (I see '#' and '*' in call UI and in pcap traces).

Regards,

···

--
Seb

Le 29/06/11 00:13, Chris Maciejewski a �crit :

I have an entire office dialing *97 (voicemail) just fine. There is
something at your end that is off.

                        Lee

Very odd...

Just tried Jitis nightly build 3561 on Ubuntu and Windows and got the
same result - # characters is stripped.

Please see PDF for more details:

http://dl.dropbox.com/u/3182365/Jitsi-HashCharacter.pdf

Any more information I can provide about my environment that might
help to pin down this strange issue?

Chris


#6

OK, after further investigation it seems to me the problem is with
Google PhoneNumberUtil.

When I replace 'normalize' method in
plugin/addrbook/PhoneNumberI18nServiceImpl.java with:

    public String normalize(String phoneNumber)

    {

      System.out.println("Number before
PhoneNumberUtil.normalizeDigitsOnly " + phoneNumber);

        phoneNumber = PhoneNumberUtil.normalizeDigitsOnly(

                    PhoneNumberUtil.convertAlphaCharactersInNumber(

                            phoneNumber));

      System.out.println("Number after
PhoneNumberUtil.normalizeDigitsOnly " + phoneNumber);

      return phoneNumber;

    }

type #2222 in contact search field and press "Call Contact" what I get
in the console is:

[java] Number before PhoneNumberUtil.normalizeDigitsOnly #2222
[java] Number after PhoneNumberUtil.normalizeDigitsOnly 2222

And this is why my INVITE is to sip:2222 and not to sip:#2222

Cheers
Chris

···

On 28 June 2011 23:13, Chris Maciejewski <chris@wima.co.uk> wrote:

I have an entire office dialing *97 (voicemail) just fine. There is
something at your end that is off.

                   Lee

Very odd...

Just tried Jitis nightly build 3561 on Ubuntu and Windows and got the
same result - # characters is stripped.

Please see PDF for more details:

http://dl.dropbox.com/u/3182365/Jitsi-HashCharacter.pdf

Any more information I can provide about my environment that might
help to pin down this strange issue?

Chris


#7

Hey Chris,

It maybe that the PhoneNumberUtil uses the Locale and in your case this causes a problem. Could you please tell us what your system locale is?

Cheers,
Yana

···

On Jun 29, 2011, at 6:16 PM, Chris Maciejewski wrote:

OK, after further investigation it seems to me the problem is with
Google PhoneNumberUtil.

When I replace 'normalize' method in
plugin/addrbook/PhoneNumberI18nServiceImpl.java with:

   public String normalize(String phoneNumber)

   {

     System.out.println("Number before
PhoneNumberUtil.normalizeDigitsOnly " + phoneNumber);

       phoneNumber = PhoneNumberUtil.normalizeDigitsOnly(

                   PhoneNumberUtil.convertAlphaCharactersInNumber(

                           phoneNumber));

     System.out.println("Number after
PhoneNumberUtil.normalizeDigitsOnly " + phoneNumber);

     return phoneNumber;

   }

type #2222 in contact search field and press "Call Contact" what I get
in the console is:

[java] Number before PhoneNumberUtil.normalizeDigitsOnly #2222
[java] Number after PhoneNumberUtil.normalizeDigitsOnly 2222

And this is why my INVITE is to sip:2222 and not to sip:#2222

Cheers
Chris

On 28 June 2011 23:13, Chris Maciejewski <chris@wima.co.uk> wrote:

I have an entire office dialing *97 (voicemail) just fine. There is
something at your end that is off.

                       Lee

Very odd...

Just tried Jitis nightly build 3561 on Ubuntu and Windows and got the
same result - # characters is stripped.

Please see PDF for more details:

http://dl.dropbox.com/u/3182365/Jitsi-HashCharacter.pdf

Any more information I can provide about my environment that might
help to pin down this strange issue?

Chris