[jitsi-dev] A couple of small fixes


#1

Hi,

Here are a couple of tiny patches that address some rather critical
bugs that I've noticed. OK, maybe not that critical.

smileys.patch: Fixes the "view smileys" checkbox under tools in the
chat window, a.t.m. it has no effect.

ice-config-panel-port-field.patch: Fixes a bug where the user can
click "ok" even if an invalid port number is entered in the form,
causing an exception that isn't handled.

aol-url.patch: Apparently the URL for new AOL registrations has
changed. You wouldn't want to deprive AOL from all the new users
coming from Jitsi, right?

xx.png: This is not a patch, since apparently subversion cannot handle
binary patches. The
trunk/resources/images/plugin/spellcheck/flags/xx.png file (used to
display the flag for Basque, Armenian, Esperanto, Interlingua and
Kiswahili languages in the spellchecker) has the flag of the USA. The
attached file is a blank (transparent) png, which I think is more
appropriate.

Boris

smileys.patch (1.22 KB)

ice-config-panel-port-field.patch (2 KB)

aol-url.patch (686 Bytes)


#2

Sending a clean version of ice-config-panel-port-field.patch

ice-config-panel-port-field.patch (1022 Bytes)


#3

Hey again Boris,

Hi,

Here are a couple of tiny patches that address some rather critical
bugs that I've noticed. OK, maybe not that critical.

smileys.patch: Fixes the "view smileys" checkbox under tools in the
chat window, a.t.m. it has no effect.

Good one! When you get a chance, could you please just add a quick
javadoc to the new property field that you've added?

ice-config-panel-port-field.patch: Fixes a bug where the user can
click "ok" even if an invalid port number is entered in the form,
causing an exception that isn't handled.

Even better!

aol-url.patch: Apparently the URL for new AOL registrations has
changed. You wouldn't want to deprive AOL from all the new users
coming from Jitsi, right?

Totally :wink:

xx.png: This is not a patch, since apparently subversion cannot handle
binary patches. The
trunk/resources/images/plugin/spellcheck/flags/xx.png file (used to
display the flag for Basque, Armenian, Esperanto, Interlingua and
Kiswahili languages in the spellchecker) has the flag of the USA. The
attached file is a blank (transparent) png, which I think is more
appropriate.

They are all now applied, committed and acked.

Thanks!
Emil

···

On 19.08.12, 23:38, Boris Grozev wrote:


#4

Here's one more. It fixes an exception thrown when an account is enabled
through the options window while trace logging is on.

account-list.patch (745 Bytes)


#5

Applied, committed (r9845) and acked.

Thanks,
Emil

···

On 13.09.12, 16:15, Boris Grozev wrote:

fixes an exception thrown when an account is enabled through the options
window while trace logging is on.