Desktop Sharing Frame Rate config override not working on meet.jit.si (fps)

#1

Hi there,

I’m trying to get 30fps when sharing the desktop.
So I override the desktopSharingFrameRate when loading Jitsi Meet in an iframe via the external API.

configOverwrite: {
    desktopSharingFrameRate: {
        min: 30,
        max: 30
    },
},

But Jitsi Meet keeps reporting 5fps, both locally and on the remote end.
The actual video element does seem to display in 30fps, but only locally.
The remote end displays in 5fps.

Please see if you can reproduce this using this fiddle:
https://jsfiddle.net/9nxaouwm/embedded/result/
Open two times and then share desktop in one of them.

14
142880×1596 681 KB
39
392880×1594 717 KB

#2

For this you need a custom deployment and to change: https://github.com/jitsi/lib-jitsi-meet/blob/master/modules/RTC/RTCUtils.js#L70

Edit: on the other hand your settings should be taken into account here: https://github.com/jitsi/lib-jitsi-meet/blob/master/modules/RTC/RTCUtils.js#L483

#3

I think I was able to get 30fps working with lib-jitsi-meet, connecting to the meet.jit.si server. But I ran into other issues when doing that, so right now I’m trying to get 30fps screen sharing working again with the external api…

According to the API docs it should work:

  • configOverwrite : (optional) JS object with overrides for options defined in config.js.

config.js contains the following:

    // Optional desktop sharing frame rate options. Default value: min:5, max:5.
    // desktopSharingFrameRate: {
    //     min: 5,
    //     max: 5
    // },

So overriding that setting should change the fps, but seems like it’s not completely working.
Can you reproduce the issue?

#4

Yes, I can reproduce it, it seems that setting it like this doesn’t affect the result.

#5

Sorry I don’t understand what you mean. Is there already a working way to override the fps when using the external api? Or is it a bug that needs to be fixed?

#6

Settings passed through the iframe API are correct, but it seems those are not taken into account the way we set it to the track. It needs more work and testing to fix it, any PR is welcome.

#7

Seems applying constraints to the track doesn’t work https://github.com/jitsi/lib-jitsi-meet/blob/master/modules/RTC/RTCUtils.js#L1252

#8

Thanks for tracking down the issue! It’s a bit over my head :slight_smile: