Change Desktop Share Bitrate From Client

patrick.buechi · December 14, 2022, 2:27pm

Is it possible to set a desktop share max bitrate in the connection or conference settings?

In lib-jitsi-meet it’s the constant called DESKTOP_SHARE_RATE. Can this value be overriden?

damencho · December 14, 2022, 2:34pm

Yes by providing desktopBitrate in videoQuality

jitsi/lib-jitsi-meet/blob/7b2576866383257efe66cbaa1b9745d90572e0c9/modules/RTC/TPCUtils.js#L324


      
          
          
/**
           * Returns the calculates max bitrates that need to be configured on the simulcast encodings based on the video
           * type and other considerations associated with screenshare.
           *
           * @param {JitsiLocalTrack} localVideoTrack The local video track.
           * @returns {Array<number>}
           */
          calculateEncodingsBitrates(localVideoTrack) {
              const videoType = localVideoTrack.getVideoType();
              const desktopShareBitrate = this.pc.options?.videoQuality?.desktopBitrate || DESKTOP_SHARE_RATE;
              const lowFpsScreenshare = localVideoTrack.getVideoType() === VideoType.DESKTOP
                  && this.pc._capScreenshareBitrate
                  && !browser.isWebKitBased();
              const encodingsBitrates = this.localStreamEncodingsConfig
              .map(encoding => {
                  const bitrate = lowFpsScreenshare
                      ? desktopShareBitrate
          
          
            // For high fps screenshare, 'maxBitrate' setting must be cleared on Chrome in plan-b, because
                      // if simulcast is enabled for screen and maxBitrates are set then Chrome will not send the

github.com

jitsi/jitsi-meet/blob/aef5328aeb8c187f97880b97dd5a6013c26079f4/config.js#L444


      
          //     90: 2,
          // },
          
          
// Provides a way to translate the legacy bridge signaling messages, 'LastNChangedEvent',
          // 'SelectedEndpointsChangedEvent' and 'ReceiverVideoConstraint' into the new 'ReceiverVideoConstraints' message
          // that invokes the new bandwidth allocation algorithm in the bridge which is described here
          // - https://github.com/jitsi/jitsi-videobridge/blob/master/doc/allocation.md.
          // useNewBandwidthAllocationStrategy: false,
          
          
// Specify the settings for video quality optimizations on the client.
          // videoQuality: {
          //    // Provides a way to prevent a video codec from being negotiated on the JVB connection. The codec specified
          //    // here will be removed from the list of codecs present in the SDP answer generated by the client. If the
          //    // same codec is specified for both the disabled and preferred option, the disable settings will prevail.
          //    // Note that 'VP8' cannot be disabled since it's a mandatory codec, the setting will be ignored in this case.
          //    disabledCodec: 'H264',
          //
          //    // Provides a way to set a preferred video codec for the JVB connection. If 'H264' is specified here,
          //    // simulcast will be automatically disabled since JVB doesn't support H264 simulcast yet. This will only
          //    // rearrange the the preference order of the codecs in the SDP answer generated by the browser only if the
          //    // preferred codec specified here is present. Please ensure that the JVB offers the specified codec for this

patrick.buechi · January 5, 2023, 12:59pm

Adding the above to the conference options updates the setting, as @damencho says above

conferenceOptions = {
openBridgeChannel: true,
videoQuality: {
desktopBitrate: 2000000
}
};

Eyalc · January 5, 2023, 3:47pm

Hi,

Is it possible to change it for Android (mobile) sharing as well ?

Thanks