automatically exiting full screen mode when exiting


#1

Hey Lubo,

I was having a bit of an issue with the full screen mode today and
could only fix it partially so I wondered whether you could give me a
hand.

When having a video call in full screen mode, it is possible for the
remote party to hang up the call before we've had a chance to exit.
When this was happening, it used to be impossible for the user to exit
the full screen mode once the call had ended.

The culprit was a NullPointerException in
CallParticipantPanel.exitFullScreenMode(). The
getGraphicsConfiguration() was returning null and hence the call to
the getDevice() method was throwing the exception.

I suspect the reason was that at that point the panel wasn't visible
any more, and neither was it's parent.

I've added a null check so it is now possible for the user to manually
exit FS mode. I thought however, that it would probably be better to
automatically dispose the FullScreenWindow when disposing the call
dialog. I wasn't sure what would be the best way to do this so I
thought I'd drop you a note. What do you think?

Cheers
Emil


#2

Hi Emil,

I think r4966 adds the functionality you describe and it seems to work
for me on Mac OS X.

Best regards,
Lubo

ยทยทยท

On Mon, Feb 2, 2009 at 2:05 AM, Emil Ivov <emcho@sip-communicator.org> wrote:

Hey Lubo,

I was having a bit of an issue with the full screen mode today and
could only fix it partially so I wondered whether you could give me a
hand.

When having a video call in full screen mode, it is possible for the
remote party to hang up the call before we've had a chance to exit.
When this was happening, it used to be impossible for the user to exit
the full screen mode once the call had ended.

The culprit was a NullPointerException in
CallParticipantPanel.exitFullScreenMode(). The
getGraphicsConfiguration() was returning null and hence the call to
the getDevice() method was throwing the exception.

I suspect the reason was that at that point the panel wasn't visible
any more, and neither was it's parent.

I've added a null check so it is now possible for the user to manually
exit FS mode. I thought however, that it would probably be better to
automatically dispose the FullScreenWindow when disposing the call
dialog. I wasn't sure what would be the best way to do this so I
thought I'd drop you a note. What do you think?

Cheers
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net