A few issues with Apple's Address Book support


#1

Hey Lubo,

Just tried the latest Address Book support. Searches seem to work
properly and I do get to see the contacts in my address book. Congrats!

There are a few issues though:

* I don't get the images (build 3208) in the contact list and only see
them in the tool tip.

* The call button is disabled even though the tool tip does show the
phone entries

* Searches do not seem to work on the concatenation of the first and
last names. For example, I have a contact in my Address Book, with first
name: Abc and a last name: Def. Typing Abc in my search bar does return
it among the "Address Book" results. Typing "Abc D" however no longer
works. I am not sure whether this is intentional but given we don't show
a clear distinction between first and last names in the contact list,
users are likely to expect such queries to work.

Cheers,
Emil


#2

Hey Lubo,

Just tried the latest Address Book support. Searches seem to work
properly and I do get to see the contacts in my address book. Congrats!

There are a few issues though:

* I don't get the images (build 3208) in the contact list and only see
them in the tool tip.

That's how the images work for both Mirosoft Outlook and the Address
Book of Mac OS X. I'll try to figure out what needs to be implemented
so that they get displayed in the TreeContactList as well.

* The call button is disabled even though the tool tip does show the
phone entries

I couldn't make it get enabled. (This applies to the contacts from
Microsoft Outlook as well.) I'll look into it as well.

* Searches do not seem to work on the concatenation of the first and
last names. For example, I have a contact in my Address Book, with first
name: Abc and a last name: Def. Typing Abc in my search bar does return
it among the "Address Book" results. Typing "Abc D" however no longer
works. I am not sure whether this is intentional but given we don't show
a clear distinction between first and last names in the contact list,
users are likely to expect such queries to work.

Oh, my bad, I'm sorry. The fist and last names are different
properties in the Address Book of Mac OS X and I match them separately
though I concatenate them for the displayName. I'll fix it asap.

Thanks for the prompt testing and feedback!

···

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

I tried to address the above issues in r8133. Please let me know if
they still fail to work as expected.

···

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

* The call button is disabled even though the tool tip does show the
phone entries

* Searches do not seem to work on the concatenation of the first and
last names. For example, I have a contact in my Address Book, with first
name: Abc and a last name: Def. Typing Abc in my search bar does return
it among the "Address Book" results. Typing "Abc D" however no longer
works. I am not sure whether this is intentional but given we don't show
a clear distinction between first and last names in the contact list,
users are likely to expect such queries to work.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

r8134 should remedy it. It was a problem in the UI - SourceUIContact
would get the image of the SourceContact and then would call new
ImageIcon() instead of new ImageIcon(image).

···

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

* I don't get the images (build 3208) in the contact list and only see
them in the tool tip.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Lubo, Emil,

Hey Lubo,

Just tried the latest Address Book support. Searches seem to work
properly and I do get to see the contacts in my address book. Congrats!

There are a few issues though:

* I don't get the images (build 3208) in the contact list and only see
them in the tool tip.

That's how the images work for both Mirosoft Outlook and the Address
Book of Mac OS X. I'll try to figure out what needs to be implemented
so that they get displayed in the TreeContactList as well.

I think this is most probably an issue of the implementation of TreeContactList. I'm having a look right now.

* The call button is disabled even though the tool tip does show the
phone entries

I couldn't make it get enabled. (This applies to the contacts from
Microsoft Outlook as well.) I'll look into it as well.

Again, my impressions is that this is an issue of the ui implementation. I'll be looking at it today.

Cheers,
Yana

···

On Jan 8, 2011, at 6:17 PM, Lyubomir Marinov wrote:

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

* Searches do not seem to work on the concatenation of the first and
last names. For example, I have a contact in my Address Book, with first
name: Abc and a last name: Def. Typing Abc in my search bar does return
it among the "Address Book" results. Typing "Abc D" however no longer
works. I am not sure whether this is intentional but given we don't show
a clear distinction between first and last names in the contact list,
users are likely to expect such queries to work.

Oh, my bad, I'm sorry. The fist and last names are different
properties in the Address Book of Mac OS X and I match them separately
though I concatenate them for the displayName. I'll fix it asap.

Thanks for the prompt testing and feedback!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Yana, that's really very kind of you! But it was my fault in this case.

···

On Sat, Jan 8, 2011 at 7:29 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:

* The call button is disabled even though the tool tip does show the
phone entries

I couldn't make it get enabled. (This applies to the contacts from
Microsoft Outlook as well.) I'll look into it as well.

Again, my impressions is that this is an issue of the ui implementation. I'll be looking at it today.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

На 08.01.11 20:46, Lyubomir Marinov написа:

···

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

* The call button is disabled even though the tool tip does show the
phone entries

* Searches do not seem to work on the concatenation of the first and
last names. For example, I have a contact in my Address Book, with first
name: Abc and a last name: Def. Typing Abc in my search bar does return
it among the "Address Book" results. Typing "Abc D" however no longer
works. I am not sure whether this is intentional but given we don't show
a clear distinction between first and last names in the contact list,
users are likely to expect such queries to work.

I tried to address the above issues in r8133. Please let me know if
they still fail to work as expected.

It does. Thanks!

Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

На 09.01.11 00:41, Emil Ivov написа:

На 08.01.11 20:46, Lyubomir Marinov написа:

* The call button is disabled even though the tool tip does show the
phone entries

This part however is still causing problems. Whenever I try to actually
start a call to any of the numbers there, I would either get an error
message saying that "neither of my null accounts" are connected, or
nothing would happen.

I suspect this is most likely an issue with our support for the contact
source interfaces though, since this is the first time we are using them
without a protocol preference.

Cheers,
Emil

···

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi Emil, Lubomir,

На 09.01.11 00:41, Emil Ivov написа:

На 08.01.11 20:46, Lyubomir Marinov написа:

* The call button is disabled even though the tool tip does show the
phone entries

This part however is still causing problems. Whenever I try to actually
start a call to any of the numbers there, I would either get an error
message saying that "neither of my null accounts" are connected, or
nothing would happen.

I suspect this is most likely an issue with our support for the contact
source interfaces though, since this is the first time we are using them
without a protocol preference.

I have found the problem. The GUI was expecting from the source contact detail to have at least a preferred protocol name, when no preferred provider is provided. This is because we presume that a contact like yana@gmail.com could be only called through the Jabber protocol provider for example. Of course, the problem Emil was having is still an issue. I'll fix that right now, by simply obtaining all available providers that support telephony and let the user choose by himself.

Cheers,
Yana

···

On Jan 9, 2011, at 12:43 AM, Emil Ivov wrote:

2011/1/8 Emil Ivov <emcho@sip-communicator.org>:

Cheers,
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hey folks

На 09.01.11 11:54, Yana Stamcheva написа:

I have found the problem. The GUI was expecting from the source
contact detail to have at least a preferred protocol name, when no
preferred provider is provided. This is because we presume that a
contact like yana@gmail.com could be only called through the Jabber
protocol provider for example. Of course, the problem Emil was having
is still an issue. I'll fix that right now, by simply obtaining all
available providers that support telephony and let the user choose by
himself.

Great. Works like a charm.

Lubo, Yana, thank you both for your efforts.

Now the only thing that we still need to handle is making sure that
dashes and parentheses are properly stripped from numbers since they are
common in these address books. I am still not sure what the best place
would be to do this though (i.e. contact source impl vs. protocol
provider), so we'd have to discuss this first.

Cheers
Emil

Cheers, Yana

Cheers, Emil

---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net

For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net

···

For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31


#11

Hi,

Hey folks

На 09.01.11 11:54, Yana Stamcheva написа:
Great. Works like a charm.

Lubo, Yana, thank you both for your efforts.

It is a wonderful feature indeed, thanks guys!

I've noticed one more problem though. If a contact has more than one number (say home and mobile) and there is more than one account, then after pressing the call button it shows "Call via" and then lists all the numbers (but not the accounts) allowing to click on any of them. However clicking does not have any effect.

Now the only thing that we still need to handle is making sure that
dashes and parentheses are properly stripped from numbers since they are
common in these address books.

I 100% agree with Emil here.

Best regards,

···

On 09/01/2011 18:28, Emil Ivov wrote:

--
Dmitry Panov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

What about the letters in telephone numbers such as 1-800-MY-APPLE
which Apple have automatically added to my Mac OS X Address Book? I
mean, should it become 8006927753? If it should, then should we
display it in the search results and its tool tip as it is i.e.
1-800-MY-APPLE and only convert upon calling?

···

On Sun, Jan 9, 2011 at 8:28 PM, Emil Ivov <emcho@sip-communicator.org> wrote:

Now the only thing that we still need to handle is making sure that
dashes and parentheses are properly stripped from numbers since they are
common in these address books. I am still not sure what the best place
would be to do this though (i.e. contact source impl vs. protocol
provider), so we'd have to discuss this first.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

Hi devs,

I think this number parsing must be done in protocol so we can make
use of it in various ways, like calling addressbook source contacts
and by pasting such numbers in dial field. There was recently such a
request and a suggestion for a library libphonenumber
(http://code.google.com/p/libphonenumber/). The thread:
https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=10170
.
As I'm writing I'm wondering isn't it even better to put it in UI. We
call all this numbers through UI and parsing the number there we will
reuse it for all protocols.
WDYT?

Cheers
damencho

···

On Mon, Jan 10, 2011 at 10:40 AM, Lyubomir Marinov <lubo@sip-communicator.org> wrote:

On Sun, Jan 9, 2011 at 8:28 PM, Emil Ivov <emcho@sip-communicator.org> wrote:

Now the only thing that we still need to handle is making sure that
dashes and parentheses are properly stripped from numbers since they are
common in these address books. I am still not sure what the best place
would be to do this though (i.e. contact source impl vs. protocol
provider), so we'd have to discuss this first.

What about the letters in telephone numbers such as 1-800-MY-APPLE
which Apple have automatically added to my Mac OS X Address Book? I
mean, should it become 8006927753? If it should, then should we
display it in the search results and its tool tip as it is i.e.
1-800-MY-APPLE and only convert upon calling?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

Hi,

···

On 09/01/2011 20:34, Dmitry Panov wrote:

Hi,

On 09/01/2011 18:28, Emil Ivov wrote:

Hey folks

На 09.01.11 11:54, Yana Stamcheva написа:
Great. Works like a charm.

Lubo, Yana, thank you both for your efforts.

It is a wonderful feature indeed, thanks guys!

I've noticed one more problem though. If a contact has more than one number (say home and mobile) and there is more than one account, then after pressing the call button it shows "Call via" and then lists all the numbers (but not the accounts) allowing to click on any of them. However clicking does not have any effect.

Has anyone seen this message? This issue still exists in the latest version and it's probably the last one that prevents me from migrating to SC :slight_smile:

--
Best regards,

  Dmitry Panov
  Chief Technology Officer
  Itoolabs.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#15

I'm not entirely sure how we're going to detect that the intention of
the user was to type a telephony number. I guess it's possible to have
a string that looks like a valid telephone number to the library, yet
one could use it as a protocol username... In my case, it should be
relatively clearer in the ContactSourceServices for the Address Book's
of Microsoft Outlook and Mac OS X, because I could do it only for the
values of the telephone number properties. Anyway, I also think it's
nice to do the conversion not only in the ContactSourceServices
because it sounds common to me to have telephone numbers pasted.

···

On Mon, Jan 10, 2011 at 11:01 AM, Damian Minkov <damencho@sip-communicator.org> wrote:

I think this number parsing must be done in protocol so we can make
use of it in various ways, like calling addressbook source contacts
and by pasting such numbers in dial field. There was recently such a
request and a suggestion for a library libphonenumber
(http://code.google.com/p/libphonenumber/). The thread:
https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=10170.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Hey Dmitry,

На 12.01.11 21:38, Dmitry Panov написа:

I've noticed one more problem though. If a contact has more than one
number (say home and mobile) and there is more than one account, then
after pressing the call button it shows "Call via" and then lists all
the numbers (but not the accounts) allowing to click on any of them.
However clicking does not have any effect.

Has anyone seen this message? This issue still exists in the latest
version and it's probably the last one that prevents me from migrating
to SC :slight_smile:

We have indeed. Sorry for not acknowledging. We are currently working on
resolving it. You can open an issue to track status if you wish.
Otherwise we'll simply notify the list when ready.

Cheers,
Emil

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#17

Hey all,

We've had a few off-list discussions on this one.

Basically everyone seems to agree that it would be too difficult for
protocol providers to properly determine whether or not a string is
supposed to be handled as a phone number or a SIP/XMPP URI since that
depends too much on where the string is coming from.

Therefore it will probably be best to handle this at the source (be it a
contact source or the GUI search field) so that the circumstances could
be taken into account (e.g. the fact that 1-800-ILUV-XMPP comes from the
Apple/Outlook address book means we are actually dealing with
+180045889677).

Of course we'll handle this in a number normalization service so that
the actual stripping code would be shared by all the .... strippers :wink:

Cheers,
Emil

На 10.01.11 10:10, Lyubomir Marinov написа:

···

On Mon, Jan 10, 2011 at 11:01 AM, Damian Minkov > <damencho@sip-communicator.org> wrote:

I think this number parsing must be done in protocol so we can make
use of it in various ways, like calling addressbook source contacts
and by pasting such numbers in dial field. There was recently such a
request and a suggestion for a library libphonenumber
(http://code.google.com/p/libphonenumber/). The thread:
https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=10170.

I'm not entirely sure how we're going to detect that the intention of
the user was to type a telephony number. I guess it's possible to have
a string that looks like a valid telephone number to the library, yet
one could use it as a protocol username... In my case, it should be
relatively clearer in the ContactSourceServices for the Address Book's
of Microsoft Outlook and Mac OS X, because I could do it only for the
values of the telephone number properties. Anyway, I also think it's
nice to do the conversion not only in the ContactSourceServices
because it sounds common to me to have telephone numbers pasted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#18

Hi all,

we recently discovered that on windows machine (Windows XP 32bit
probably and others) without installed outlook sip-communicator
crashes and exits just a little after showing the main window.
I reported it privately to Lyubomir and he was so kind to quickly fix
it. The fix is in build.3219.
The crash may prevent some of you to update, so you have two options:

1. Go and delete jmsoutlookaddrbook.dll. On my side its located in:
C:\Program Files\SIP Communicator\native
Then this will fix the crash and you can easily update.

2. Update by downloading the new binary from the website and install
it. Every next build including 3219 is ok.

Thanks for your patience
damencho

···

On Mon, Jan 10, 2011 at 8:40 PM, Emil Ivov <emcho@sip-communicator.org> wrote:

Hey all,

We've had a few off-list discussions on this one.

Basically everyone seems to agree that it would be too difficult for
protocol providers to properly determine whether or not a string is
supposed to be handled as a phone number or a SIP/XMPP URI since that
depends too much on where the string is coming from.

Therefore it will probably be best to handle this at the source (be it a
contact source or the GUI search field) so that the circumstances could
be taken into account (e.g. the fact that 1-800-ILUV-XMPP comes from the
Apple/Outlook address book means we are actually dealing with
+180045889677).

Of course we'll handle this in a number normalization service so that
the actual stripping code would be shared by all the .... strippers :wink:

Cheers,
Emil

На 10.01.11 10:10, Lyubomir Marinov написа:

On Mon, Jan 10, 2011 at 11:01 AM, Damian Minkov >> <damencho@sip-communicator.org> wrote:

I think this number parsing must be done in protocol so we can make
use of it in various ways, like calling addressbook source contacts
and by pasting such numbers in dial field. There was recently such a
request and a suggestion for a library libphonenumber
(http://code.google.com/p/libphonenumber/). The thread:
https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=10170.

I'm not entirely sure how we're going to detect that the intention of
the user was to type a telephony number. I guess it's possible to have
a string that looks like a valid telephone number to the library, yet
one could use it as a protocol username... In my case, it should be
relatively clearer in the ContactSourceServices for the Address Book's
of Microsoft Outlook and Mac OS X, because I could do it only for the
values of the telephone number properties. Anyway, I also think it's
nice to do the conversion not only in the ContactSourceServices
because it sounds common to me to have telephone numbers pasted.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net